Skip to content

fix(@angular-devkit/build-angular): use process TTY as progress default - #11805

Merged
filipesilva merged 1 commit into
angular:masterfrom
filipesilva:progress-tty-detection
Aug 7, 2018
Merged

fix(@angular-devkit/build-angular): use process TTY as progress default#11805
filipesilva merged 1 commit into
angular:masterfrom
filipesilva:progress-tty-detection

Conversation

@filipesilva

Copy link
Copy Markdown
Contributor

Fix #11195

@filipesilva
filipesilva requested a review from clydin August 7, 2018 12:35
@filipesilva
filipesilva merged commit 8fd1040 into angular:master Aug 7, 2018
@filipesilva
filipesilva deleted the progress-tty-detection branch August 7, 2018 16:20
@hansl

hansl commented Aug 15, 2018

Copy link
Copy Markdown
Contributor

This PR was a feature, as it changed the default behavior. It's been released in 6.1.3.

@alexeagle

Copy link
Copy Markdown
Contributor

@hansl what do you suggest we do? Cut a 6.1.4 that removes this change?

@hansl

hansl commented Aug 15, 2018

Copy link
Copy Markdown
Contributor

Actually probably the most semver option, yes. Revert it in the patch (6.1.4 is due today anyway) and leave it alone in master.

@filipesilva

Copy link
Copy Markdown
Contributor Author

This isn't a feature but rather a fix for a regression. See #11195, #8148 and #8501.

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: Don't print progress in a non-TTY context

5 participants